mirrors/codon
1
0
Fork 0
mirror of https://github.com/exaloop/codon.git synced 2025-06-03 15:03:52 +08:00
Code Issues Projects Releases Wiki Activity

Don't publish empty output; remove magic number (#27)

Browse Source
This commit is contained in:
A. R. Shajii 2022-04-23 17:14:26 -04:00 committed by GitHub
parent 753151157d
commit f9f4fb1b26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
extra/jupyter/jupyter.cpp
View File

@ -54,9 +54,11 @@ nl::json CodonJupyter::execute_request_impl(int execution_counter, const string
if (failed.empty()) {
std::string out = *result;
nl::json pub_data;
if (ast::startswith(out, "\x00\x00__codon/mime__\x00")) {
using std::string_literals::operator""s;
std::string codonMimeMagic = "\x00\x00__codon/mime__\x00"s;
if (ast::startswith(out, codonMimeMagic)) {
std::string mime = "";
int i = 17;
int i = codonMimeMagic.size();
for (; i < out.size() && out[i]; i++)
mime += out[i];
if (i < out.size() && !out[i]) {
@ -70,7 +72,8 @@ nl::json CodonJupyter::execute_request_impl(int execution_counter, const string
} else {
pub_data["text/plain"] = out;
}
publish_execution_result(execution_counter, move(pub_data), nl::json::object());
if (!out.empty())
publish_execution_result(execution_counter, move(pub_data), nl::json::object());
return nl::json{{"status", "ok"},
{"payload", nl::json::array()},
{"user_expressions", nl::json::object()}};