Enable most of C++ tests on ROCm (#3786)

Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3786

ROCm build successfully passes all but 2 GPU tests and we want to enable the passing test on CI while skipping the 2 failing tests to make progress. The 2 failing tests are failing specifically on the hardware type that we use for our runners and the AMD team is actively working on root causing it and providing a fix:
`TestGpuIndexIVFPQ.Query_L2_MMCodeDistance`
`TestGpuIndexIVFPQ.Query_IP_MMCodeDistance`

Reviewed By: asadoughi

Differential Revision: D61688657

fbshipit-source-id: 3fedfcf22a0ccf40ac8aff033e8bc09c4eb0cbd5
pull/3798/head
Ramil Bakhshyiev 2024-08-23 10:58:14 -07:00 committed by Facebook GitHub Bot
parent 6053348b2e
commit 58a673d938
2 changed files with 3 additions and 1 deletions

View File

@ -131,7 +131,6 @@ runs:
.
make -k -C build -j$(nproc)
- name: C++ tests
if: inputs.rocm == 'OFF'
shell: bash
run: |
export GTEST_OUTPUT="xml:$(realpath .)/test-results/googletest/"

View File

@ -307,6 +307,8 @@ void testMMCodeDistance(faiss::MetricType mt) {
}
}
// FIXME: https://github.com/facebookresearch/faiss/issues/3787
#ifndef USE_AMD_ROCM
TEST(TestGpuIndexIVFPQ, Query_L2_MMCodeDistance) {
testMMCodeDistance(faiss::MetricType::METRIC_L2);
}
@ -314,6 +316,7 @@ TEST(TestGpuIndexIVFPQ, Query_L2_MMCodeDistance) {
TEST(TestGpuIndexIVFPQ, Query_IP_MMCodeDistance) {
testMMCodeDistance(faiss::MetricType::METRIC_INNER_PRODUCT);
}
#endif // USE_AMD_ROCM
TEST(TestGpuIndexIVFPQ, Float16Coarse) {
Options opt;