From a3cd63fb6aa5cb910cfa7ddb388ce6559867c4af Mon Sep 17 00:00:00 2001 From: Aditya Vidyadhar Kamath Date: Wed, 16 Apr 2025 22:50:42 -0700 Subject: [PATCH] Skip mmap test case in AIX. (#4275) Summary: In AIX, the recent mmap feature is not implemented. So we can skip these test case. In our internal CI's when we run the test cases, we have two failures. 21/132 Test https://github.com/facebookresearch/faiss/issues/21: TestMmap.mmap_flatcodes ...........................................***Failed 0.03 sec Start 22: TestMmap.mmap_binary_flatcodes 22/132 Test https://github.com/facebookresearch/faiss/issues/22: TestMmap.mmap_binary_flatcodes ....................................***Failed 0.04 sec Currently these two test cases run since it is written in C. We want to block them like the PR [here](https://github.com/facebookresearch/faiss/commit/df9e2c48d6504fbc6052743aee6bf0b3e4b1f486#diff-26824e205001fe146a1634cf74c1dda1cdb8a07b6216545990b773a12da705d4R15-R489) does. Kindly let me know what you think. Pull Request resolved: https://github.com/facebookresearch/faiss/pull/4275 Reviewed By: junjieqi Differential Revision: D72483472 Pulled By: bshethmeta fbshipit-source-id: ad13b2dc2797ee51e670e01800d1f8ba0f6632c1 --- tests/test_mmap.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/test_mmap.cpp b/tests/test_mmap.cpp index 800ffc2e6..78549d687 100644 --- a/tests/test_mmap.cpp +++ b/tests/test_mmap.cpp @@ -60,6 +60,9 @@ std::vector make_binary_data( // on top of the existing File1 again TEST(TestMmap, mmap_flatcodes) { +#ifdef _AIX + GTEST_SKIP() << "Skipping test on AIX."; +#endif // generate data const size_t nt = 1000; const size_t nq = 10; @@ -161,6 +164,9 @@ TEST(TestMmap, mmap_flatcodes) { } TEST(TestMmap, mmap_binary_flatcodes) { +#ifdef _AIX + GTEST_SKIP() << "Skipping test on AIX."; +#endif // generate data const size_t nt = 1000; const size_t nq = 10;