mirrors/faiss
1
0
Fork 0
mirror of https://github.com/facebookresearch/faiss.git synced 2025-06-03 21:54:02 +08:00
Code Issues Projects Releases Wiki Activity

assign_index should default to null (#3855)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3855

Laser clients are calling RCQ search with a query size of 1 and the bulk of the overhead came from IndexFlat add/search. With a small query size, using IndexFlatL2 does lots of unnecessary copies to the IndexFlatL2.

By default, we should fall back to https://fburl.com/code/jpt236mz branch unless the client overrides `assign_index` with `assign_index_factory`.

Reviewed By: bshethmeta

Differential Revision: D62644305

fbshipit-source-id: 2434e2b238968304dc5b346637f8ca956e6bd548
This commit is contained in:
Mengdi Lin 2024-09-13 10:53:32 -07:00 committed by Facebook GitHub Bot
parent 52ce3f55ae
commit dbdd63bce5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
faiss/impl/residual_quantizer_encode_steps.cpp
View File

@ -664,8 +664,6 @@ void refine_beam_mp(
std::unique_ptr<Index> assign_index;
if (rq.assign_index_factory) {
assign_index.reset((*rq.assign_index_factory)(rq.d));
} else {
assign_index.reset(new IndexFlatL2(rq.d));
}
// main loop
@ -701,7 +699,9 @@ void refine_beam_mp(
assign_index.get(),
rq.approx_topk_mode);
assign_index->reset();
if (assign_index != nullptr) {
assign_index->reset();
}
std::swap(codes_ptr, new_codes_ptr);
std::swap(residuals_ptr, new_residuals_ptr);