Michael Norris
|
fd6d784114
|
Resolve "incorrect-portions-license" errors: add no license lint to top of GPU files with both licenses (#3965)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3965
End goal: add some lint to prevent files landing without any header. This creates churn for the oncall. Example is the last diff in this stack: D64488600
This is the first diff in enabling linting. I wanted the diff which updates all files to be just the automated command and the .toml config files changes, so this diff is a preparation step.
This particular diff solves: we get errors due to having both NVidia and FB license comment headers in the same files. See the errors in D64429711 under "linter-coverage-verification" signal.
Context on linting: https://fb.workplace.com/groups/lintqa/posts/3762373340693743/?comment_id=3762915930639484&reply_comment_id=3763044163959994
Per OSS, we cannot remove the Nvidia notice: https://fb.workplace.com/groups/osssupport/posts/27179779734977284/?comment_id=27181801724775085&reply_comment_id=27181818148106776
So, we add the lint ignore here.
Reviewed By: asadoughi
Differential Revision: D64481766
fbshipit-source-id: 0468104a095831cac7dd5bf3c519cfb5a2ee1575
|
2024-10-20 18:07:08 -07:00 |
Lucas Hosseini