eff0898a13
Enable linting: lint config changes plus arc lint command ( #3966 )
...
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3966
This actually enables the linting.
Manual changes:
- tools/arcanist/lint/fbsource-licenselint-config.toml
- tools/arcanist/lint/fbsource-lint-engine.toml
Automated changes:
`arc lint --apply-patches --take LICENSELINT --paths-cmd 'hg files faiss'`
Reviewed By: asadoughi
Differential Revision: D64484165
fbshipit-source-id: 4f2f6e953c94ef6ebfea8a5ae035ccfbea65ed04
2024-10-22 09:46:48 -07:00
bf8bd6b689
Delete all remaining print ( #3452 )
...
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3452
Delete all remaining print within the Tests to improve the readability and effectiveness of the codebase.
Reviewed By: junjieqi
Differential Revision: D57466393
fbshipit-source-id: 6ebd66ae2e769894d810d4ba7a5f69fc865b797d
2024-05-16 19:51:07 -07:00
1c1d5c808f
Make tests a little less verbose
...
Summary: Useful info on github test runs is burried in spurious logging. Avoid this.
Reviewed By: mlomeli1
Differential Revision: D47209139
fbshipit-source-id: b5111c91e2b94f0c3678d599197f8e7094993df1
2023-07-04 07:02:53 -07:00
2d380e992b
Add manifold check for size 0 ( #1867 )
...
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/1867
Merging code for the 1T photodna index seems to fail at
https://www.internalfb.com/phabricator/paste/view/P412975011?lines=174
with
```
terminate called after throwing an instance of 'facebook::manifold::blobstore::StorageException'
what(): [400] Begin offset and/or length were invalid -- Begin offset must be positive and length must be non-negative. Received: offset = 2642410612, length = 0
Aborted (core dumped)
```
traces back to
https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/fbcode/manifold/blobstore/BlobstoreThriftHandler.cpp?lines=671%2C700%2C732
There is a single case where we don't check if the read or write size is 0. So let's try this fix.
In the process I realized that the Manifold tests were non functional due to a name collision on common.py. Also fix this in all dependent files.
Differential Revision: D28231710
fbshipit-source-id: 700ffa6ca0c82c49e7d1eae9e76549ec5ff16332
2021-05-09 22:30:31 -07:00
Michael Norris
Xiao Fu
Matthijs Douze
Matthijs Douze