Commit Graph

3 Commits (da20af4ca5cf7e077270f7443bd1a01c7db2cbb0)

Author SHA1 Message Date
Kumar Saurabh Arora 6fe4640d5c Fixing headers as per OSS requirement (#3847)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3847

same as title.
Fixing headers as raised in task - P1558157110

Reviewed By: junjieqi

Differential Revision: D62408917

fbshipit-source-id: 652b55dd2ba9617edeb2b05172be0f42291d7035
2024-09-09 22:58:05 -07:00
Warmchay c9c86f0daa Fix missing overload variable in Rocksdb ivf demo (#3326)
Summary:
**Bugs:**
When following rocksdb_ivf demo to build executable file, its output as:
```bash
faiss/demos/rocksdb_ivf/RocksDBInvertedLists.h:52:35: error: 'faiss::InvertedListsIterator* faiss_rocksdb::RocksDBInvertedLists::get_iterator(size_t) const' marked 'override', but does not override
   52 |     faiss::InvertedListsIterator* get_iterator(size_t list_no) const override;
      |                                   ^~~~~~~~~~~~
make[2]: *** [CMakeFiles/demo_rocksdb_ivf.dir/build.make:90: CMakeFiles/demo_rocksdb_ivf.dir/RocksDBInvertedLists.cpp.o] Error 1
```

**Solution:**
Add relevant variable `void* inverted_list_contex` corresponding `get_iterator`'s base virtual function.

Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3326

Reviewed By: mlomeli1, mdouze

Differential Revision: D55629580

Pulled By: algoriddle

fbshipit-source-id: a12fcacb483e0dd576411ad91a3dd1e0de94abec
2024-04-02 06:11:53 -07:00
Gergely Szilvasy 51b6083187 faiss on rocksdb demo (#3216)
Summary: Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3216

Reviewed By: mdouze

Differential Revision: D53051090

Pulled By: algoriddle

fbshipit-source-id: 13a027db36207af9be11a2f181116994b2aff2cb
2024-01-25 07:39:53 -08:00