3 Commits

Author SHA1 Message Date
Pankaj Singh
d657dfbf66 fix merge_flat_ondisk stress run failures (#3999)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3999

Fixed the bug causing `merge_flat_ondisk` stress run failures.

Running multiple `merge_flat_ondisk` tests simultaneously fails which is causing buck stress-run failures.
https://www.internalfb.com/intern/test/562950025349567/

Root cause: we were updating input copy (which was discarded) of the filename template instead of the local copy.

Reviewed By: asadoughi

Differential Revision: D65074463

fbshipit-source-id: 9f86deeb56975a3be7a15a8f56d602463cad61af
2024-10-28 18:54:58 -07:00
Michael Norris
eff0898a13 Enable linting: lint config changes plus arc lint command (#3966)
Summary:
Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3966

This actually enables the linting.

Manual changes:
- tools/arcanist/lint/fbsource-licenselint-config.toml
- tools/arcanist/lint/fbsource-lint-engine.toml

Automated changes:
`arc lint --apply-patches --take LICENSELINT --paths-cmd 'hg files faiss'`

Reviewed By: asadoughi

Differential Revision: D64484165

fbshipit-source-id: 4f2f6e953c94ef6ebfea8a5ae035ccfbea65ed04
2024-10-22 09:46:48 -07:00
John Mazanec
12b92e9fa5 Skip HNSWPQ sdc init with new io flag (#3250)
Summary:
## Description

Related issue: https://github.com/facebookresearch/faiss/issues/3246

When reading HNSWPQ from disk, if index ~read only~ new `IO_FLAG_PQ_SKIP_SDC_TABLE` flag is set, skip initializing the sdc_table.

In addition, adds cpp test case verifying functionality and build test util header file to share creation of temporary files amongst tests.

Pull Request resolved: https://github.com/facebookresearch/faiss/pull/3250

Test Plan: buck test //faiss/tests/:test_disable_pq_sdc_tables

Reviewed By: junjieqi

Differential Revision: D53844075

Pulled By: mdouze

fbshipit-source-id: e9a83c0e5243867edbca8f80e3b1242b38ef6a42
2024-03-01 04:27:49 -08:00