2022-08-31 14:11:38 +08:00
# Contributing to MMClassification
2022-06-02 15:22:01 +08:00
2022-08-31 14:11:38 +08:00
- [Contributing to MMClassification ](#contributing-to-mmclassification )
- [Workflow ](#workflow )
- [Code style ](#code-style )
- [Python ](#python )
- [C++ and CUDA ](#c-and-cuda )
- [Pre-commit Hook ](#pre-commit-hook )
Thanks for your interest in contributing to MMClassification! All kinds of contributions are welcome, including but not limited to the following.
2022-06-02 15:22:01 +08:00
- Fix typo or bugs
- Add documentation or translate the documentation into other languages
- Add new features and components
## Workflow
2022-08-31 14:11:38 +08:00
We recommend the potential contributors follow this workflow for contribution.
1. Fork and pull the latest MMClassification repository, follow [get_started ](./docs/en/get_started.md ) to setup the environment.
2. Checkout a new branch (**do not use the master or dev branch** for PRs)
2022-06-02 15:22:01 +08:00
2022-08-31 14:11:38 +08:00
```bash
git checkout -b xxxx # xxxx is the name of new branch
2022-06-02 15:22:01 +08:00
```
2022-08-31 14:11:38 +08:00
3. Edit the related files follow the code style mentioned below
4. Use [pre-commit hook ](https://pre-commit.com/ ) to check and format your changes.
5. Commit your changes
6. Create a PR with related information
2022-06-02 15:22:01 +08:00
## Code style
### Python
We adopt [PEP8 ](https://www.python.org/dev/peps/pep-0008/ ) as the preferred code style.
We use the following tools for linting and formatting:
- [flake8 ](https://github.com/PyCQA/flake8 ): A wrapper around some linter tools.
- [isort ](https://github.com/timothycrosley/isort ): A Python utility to sort imports.
- [yapf ](https://github.com/google/yapf ): A formatter for Python files.
- [codespell ](https://github.com/codespell-project/codespell ): A Python utility to fix common misspellings in text files.
- [mdformat ](https://github.com/executablebooks/mdformat ): Mdformat is an opinionated Markdown formatter that can be used to enforce a consistent style in Markdown files.
- [docformatter ](https://github.com/myint/docformatter ): A formatter to format docstring.
2022-08-31 14:11:38 +08:00
Style configurations of yapf and isort can be found in [setup.cfg ](./setup.cfg ).
### C++ and CUDA
We follow the [Google C++ Style Guide ](https://google.github.io/styleguide/cppguide.html ).
## Pre-commit Hook
2022-06-02 15:22:01 +08:00
We use [pre-commit hook ](https://pre-commit.com/ ) that checks and formats for `flake8` , `yapf` , `isort` , `trailing whitespaces` , `markdown files` ,
fixes `end-of-files` , `double-quoted-strings` , `python-encoding-pragma` , `mixed-line-ending` , sorts `requirments.txt` automatically on every commit.
2022-08-31 14:11:38 +08:00
The config for a pre-commit hook is stored in [.pre-commit-config ](./.pre-commit-config.yaml ).
2022-06-02 15:22:01 +08:00
After you clone the repository, you will need to install initialize pre-commit hook.
```shell
pip install -U pre-commit
```
From the repository folder
```shell
pre-commit install
```
After this on every commit check code linters and formatter will be enforced.
2022-08-31 14:11:38 +08:00
> Before you create a PR, make sure that your code lints and is formatted by yapf.