mirrors/mmcv
1
0
Fork 0
mirror of https://github.com/open-mmlab/mmcv.git synced 2025-06-03 21:54:52 +08:00
Code Issues Projects Releases Wiki Activity

[Fix] Fixed version comparison to include prerelease versions (#1877)

Browse Source 
* Fixed version comparison to include prerelease versions

Currently all tagged versions of torch 1.11.0 have version 1.11.0a0. Previously the comparison to 1.11.0 failed and self._sync_params() was still used, causing an error. This fix should include all versions of 1.11.

* Same update

Didn't realize that 1.11.0 was mentioned multiple times in the file. This fixes the other instances.
This commit is contained in:
mattcasey02 2022-04-17 22:47:56 -04:00 committed by GitHub
parent 5221a3883c
commit 6f6b17e65f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mmcv/parallel/distributed.py
View File

@ -45,7 +45,7 @@ class MMDistributedDataParallel(DistributedDataParallel):
logger='mmcv') logger='mmcv')
if ('parrots' not in TORCH_VERSION if ('parrots' not in TORCH_VERSION
and digit_version(TORCH_VERSION) >= digit_version('1.11.0')): and digit_version(TORCH_VERSION) >= digit_version('1.11.0a0')):
if self._check_sync_bufs_pre_fwd(): if self._check_sync_bufs_pre_fwd():
self._sync_buffers() self._sync_buffers()
else: else:
@ -65,7 +65,7 @@ class MMDistributedDataParallel(DistributedDataParallel):
output = self.module.train_step(*inputs, **kwargs) output = self.module.train_step(*inputs, **kwargs)
if ('parrots' not in TORCH_VERSION if ('parrots' not in TORCH_VERSION
and digit_version(TORCH_VERSION) >= digit_version('1.11.0')): and digit_version(TORCH_VERSION) >= digit_version('1.11.0a0')):
if self._check_sync_bufs_post_fwd(): if self._check_sync_bufs_post_fwd():
self._sync_buffers() self._sync_buffers()
@ -100,7 +100,7 @@ class MMDistributedDataParallel(DistributedDataParallel):
logger='mmcv') logger='mmcv')
if ('parrots' not in TORCH_VERSION if ('parrots' not in TORCH_VERSION
and digit_version(TORCH_VERSION) >= digit_version('1.11.0')): and digit_version(TORCH_VERSION) >= digit_version('1.11.0a0')):
if self._check_sync_bufs_pre_fwd(): if self._check_sync_bufs_pre_fwd():
self._sync_buffers() self._sync_buffers()
else: else:
@ -120,7 +120,7 @@ class MMDistributedDataParallel(DistributedDataParallel):
output = self.module.val_step(*inputs, **kwargs) output = self.module.val_step(*inputs, **kwargs)
if ('parrots' not in TORCH_VERSION if ('parrots' not in TORCH_VERSION
and digit_version(TORCH_VERSION) >= digit_version('1.11.0')): and digit_version(TORCH_VERSION) >= digit_version('1.11.0a0')):
if self._check_sync_bufs_post_fwd(): if self._check_sync_bufs_post_fwd():
self._sync_buffers() self._sync_buffers()