mirrors/mmengine
1
0
Fork 0
mirror of https://github.com/open-mmlab/mmengine.git synced 2025-06-03 21:54:44 +08:00
Code Issues Projects Releases Wiki Activity

[Fix] Fix MessageHub sets resumed key twice (#839)

Browse Source 
* Fix message hub

* Remove _set_resumed_keys in update_scalars and update_info_dict

* remove  in update_scalars

* clean unnecessary code
This commit is contained in:
Mashiro 2022-12-20 12:21:29 +08:00 committed by GitHub
parent b44048aeb7
commit 2eede1b97e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mmengine/logging/message_hub.py
View File

@ -173,19 +173,18 @@ class MessageHub(ManagerMixin):
assert isinstance(log_dict, dict), ('`log_dict` must be a dict!, ' assert isinstance(log_dict, dict), ('`log_dict` must be a dict!, '
f'but got {type(log_dict)}') f'but got {type(log_dict)}')
for log_name, log_val in log_dict.items(): for log_name, log_val in log_dict.items():
self._set_resumed_keys(log_name, resumed)
if isinstance(log_val, dict): if isinstance(log_val, dict):
assert 'value' in log_val, \ assert 'value' in log_val, \
f'value must be defined in {log_val}' f'value must be defined in {log_val}'
count = self._get_valid_value(log_val.get('count', 1)) count = self._get_valid_value(log_val.get('count', 1))
checked_value = self._get_valid_value(log_val['value']) value = log_val['value']
else: else:
count = 1 count = 1
checked_value = self._get_valid_value(log_val) value = log_val
assert isinstance(count, assert isinstance(count,
int), ('The type of count must be int. but got ' int), ('The type of count must be int. but got '
f'{type(count): {count}}') f'{type(count): {count}}')
self.update_scalar(log_name, checked_value, count) self.update_scalar(log_name, value, count, resumed)
def update_info(self, key: str, value: Any, resumed: bool = True) -> None: def update_info(self, key: str, value: Any, resumed: bool = True) -> None:
"""Update runtime information. """Update runtime information.
@ -208,7 +207,6 @@ class MessageHub(ManagerMixin):
could be resumed. could be resumed.
""" """
self._set_resumed_keys(key, resumed) self._set_resumed_keys(key, resumed)
self._resumed_keys[key] = resumed
self._runtime_info[key] = value self._runtime_info[key] = value
def update_info_dict(self, info_dict: dict, resumed: bool = True) -> None: def update_info_dict(self, info_dict: dict, resumed: bool = True) -> None:
@ -233,7 +231,6 @@ class MessageHub(ManagerMixin):
assert isinstance(info_dict, dict), ('`log_dict` must be a dict!, ' assert isinstance(info_dict, dict), ('`log_dict` must be a dict!, '
f'but got {type(info_dict)}') f'but got {type(info_dict)}')
for key, value in info_dict.items(): for key, value in info_dict.items():
self._set_resumed_keys(key, resumed)
self.update_info(key, value, resumed=resumed) self.update_info(key, value, resumed=resumed)
def _set_resumed_keys(self, key: str, resumed: bool) -> None: def _set_resumed_keys(self, key: str, resumed: bool) -> None: