mirrors/mmengine
1
0
Fork 0
mirror of https://github.com/open-mmlab/mmengine.git synced 2025-06-03 21:54:44 +08:00
Code Issues Projects Releases Wiki Activity

Fix: avoid modification of scalar_dict in LocalVisBackend (#377)

Browse Source
This commit is contained in:
Mashiro 2022-07-20 16:03:01 +08:00 committed by GitHub
parent 5b648c119f
commit ea61bf6bb7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mmengine/visualization/vis_backend.py
View File

@ -1,4 +1,5 @@
# Copyright (c) OpenMMLab. All rights reserved. # Copyright (c) OpenMMLab. All rights reserved.
import copy
import functools import functools
import os import os
import os.path as osp import os.path as osp
@ -291,6 +292,7 @@ class LocalVisBackend(BaseVisBackend):
Default to None. Default to None.
""" """
assert isinstance(scalar_dict, dict) assert isinstance(scalar_dict, dict)
scalar_dict = copy.deepcopy(scalar_dict)
scalar_dict.setdefault('step', step) scalar_dict.setdefault('step', step)
if file_path is not None: if file_path is not None:
@ -542,7 +544,8 @@ class TensorboardVisBackend(BaseVisBackend):
value (int, float, torch.Tensor, np.ndarray): Value to save. value (int, float, torch.Tensor, np.ndarray): Value to save.
step (int): Global step value to record. Default to 0. step (int): Global step value to record. Default to 0.
""" """
if isinstance(value, (int, float, torch.Tensor, np.ndarray)): if isinstance(value,
(int, float, torch.Tensor, np.ndarray, np.number)):
self._tensorboard.add_scalar(name, value, step) self._tensorboard.add_scalar(name, value, step)
else: else:
warnings.warn(f'Got {type(value)}, but numpy array, torch tensor, ' warnings.warn(f'Got {type(value)}, but numpy array, torch tensor, '

15
tests/test_visualizer/test_vis_backend.py
View File

@ -86,6 +86,7 @@ class TestLocalVisBackend:
input_dict = {'map': 0.7, 'acc': 0.9} input_dict = {'map': 0.7, 'acc': 0.9}
local_vis_backend = LocalVisBackend('temp_dir') local_vis_backend = LocalVisBackend('temp_dir')
local_vis_backend.add_scalars(input_dict) local_vis_backend.add_scalars(input_dict)
assert input_dict == {'map': 0.7, 'acc': 0.9}
out_dict = load(local_vis_backend._scalar_save_file, 'json') out_dict = load(local_vis_backend._scalar_save_file, 'json')
assert out_dict == {'map': 0.7, 'acc': 0.9, 'step': 0} assert out_dict == {'map': 0.7, 'acc': 0.9, 'step': 0}
@ -143,7 +144,19 @@ class TestTensorboardVisBackend:
# test append mode # test append mode
tensorboard_vis_backend.add_scalar('map', 0.9, step=0) tensorboard_vis_backend.add_scalar('map', 0.9, step=0)
tensorboard_vis_backend.add_scalar('map', 0.95, step=1) tensorboard_vis_backend.add_scalar('map', 0.95, step=1)
# test with numpy
with pytest.warns(None) as record:
tensorboard_vis_backend.add_scalar('map', np.array(0.9), step=0)
tensorboard_vis_backend.add_scalar('map', np.array(0.95), step=1)
tensorboard_vis_backend.add_scalar('map', np.array(9), step=0)
tensorboard_vis_backend.add_scalar('map', np.array(95), step=1)
tensorboard_vis_backend.add_scalar('map', np.array([9])[0], step=0)
tensorboard_vis_backend.add_scalar(
'map', np.array([95])[0], step=1)
assert len(record) == 0
# test with tensor
tensorboard_vis_backend.add_scalar('map', torch.tensor(0.9), step=0)
tensorboard_vis_backend.add_scalar('map', torch.tensor(0.95), step=1)
# Unprocessable data will output a warning message # Unprocessable data will output a warning message
with pytest.warns(Warning): with pytest.warns(Warning):
tensorboard_vis_backend.add_scalar('map', [0.95]) tensorboard_vis_backend.add_scalar('map', [0.95])