2021-08-17 14:16:55 +08:00
|
|
|
# Copyright (c) OpenMMLab. All rights reserved.
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
from typing import Union
|
|
|
|
|
2021-03-11 10:32:37 +08:00
|
|
|
import torch
|
|
|
|
import torch.nn as nn
|
|
|
|
|
2022-05-10 12:15:20 +00:00
|
|
|
from mmseg.registry import MODELS
|
2023-05-15 14:20:42 +08:00
|
|
|
from .utils import weight_reduce_loss
|
|
|
|
|
|
|
|
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
def _expand_onehot_labels_dice(pred: torch.Tensor,
|
|
|
|
target: torch.Tensor) -> torch.Tensor:
|
|
|
|
"""Expand onehot labels to match the size of prediction.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
pred (torch.Tensor): The prediction, has a shape (N, num_class, H, W).
|
|
|
|
target (torch.Tensor): The learning label of the prediction,
|
|
|
|
has a shape (N, H, W).
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
torch.Tensor: The target after one-hot encoding,
|
|
|
|
has a shape (N, num_class, H, W).
|
|
|
|
"""
|
|
|
|
num_classes = pred.shape[1]
|
|
|
|
one_hot_target = torch.clamp(target, min=0, max=num_classes)
|
|
|
|
one_hot_target = torch.nn.functional.one_hot(one_hot_target,
|
|
|
|
num_classes + 1)
|
|
|
|
one_hot_target = one_hot_target[..., :num_classes].permute(0, 3, 1, 2)
|
|
|
|
return one_hot_target
|
|
|
|
|
|
|
|
|
|
|
|
def dice_loss(pred: torch.Tensor,
|
|
|
|
target: torch.Tensor,
|
|
|
|
weight: Union[torch.Tensor, None],
|
|
|
|
eps: float = 1e-3,
|
|
|
|
reduction: Union[str, None] = 'mean',
|
|
|
|
naive_dice: Union[bool, None] = False,
|
|
|
|
avg_factor: Union[int, None] = None,
|
|
|
|
ignore_index: Union[int, None] = 255) -> float:
|
2023-05-15 14:20:42 +08:00
|
|
|
"""Calculate dice loss, there are two forms of dice loss is supported:
|
|
|
|
|
|
|
|
- the one proposed in `V-Net: Fully Convolutional Neural
|
|
|
|
Networks for Volumetric Medical Image Segmentation
|
|
|
|
<https://arxiv.org/abs/1606.04797>`_.
|
|
|
|
- the dice loss in which the power of the number in the
|
|
|
|
denominator is the first power instead of the second
|
|
|
|
power.
|
2021-03-11 10:32:37 +08:00
|
|
|
|
2023-05-15 14:20:42 +08:00
|
|
|
Args:
|
|
|
|
pred (torch.Tensor): The prediction, has a shape (n, *)
|
|
|
|
target (torch.Tensor): The learning label of the prediction,
|
|
|
|
shape (n, *), same shape of pred.
|
|
|
|
weight (torch.Tensor, optional): The weight of loss for each
|
|
|
|
prediction, has a shape (n,). Defaults to None.
|
|
|
|
eps (float): Avoid dividing by zero. Default: 1e-3.
|
|
|
|
reduction (str, optional): The method used to reduce the loss into
|
|
|
|
a scalar. Defaults to 'mean'.
|
|
|
|
Options are "none", "mean" and "sum".
|
|
|
|
naive_dice (bool, optional): If false, use the dice
|
|
|
|
loss defined in the V-Net paper, otherwise, use the
|
|
|
|
naive dice loss in which the power of the number in the
|
|
|
|
denominator is the first power instead of the second
|
|
|
|
power.Defaults to False.
|
|
|
|
avg_factor (int, optional): Average factor that is used to average
|
|
|
|
the loss. Defaults to None.
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
ignore_index (int, optional): The label index to be ignored.
|
|
|
|
Defaults to 255.
|
2023-05-15 14:20:42 +08:00
|
|
|
"""
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
num_classes = pred.shape[1]
|
|
|
|
pred = pred[:, torch.arange(num_classes) != ignore_index, :, :]
|
|
|
|
target = target[:, torch.arange(num_classes) != ignore_index, :, :]
|
|
|
|
assert pred.shape[1] != 0 # if the ignored index is the only class
|
2023-05-15 14:20:42 +08:00
|
|
|
input = pred.flatten(1)
|
|
|
|
target = target.flatten(1).float()
|
|
|
|
a = torch.sum(input * target, 1)
|
|
|
|
if naive_dice:
|
|
|
|
b = torch.sum(input, 1)
|
|
|
|
c = torch.sum(target, 1)
|
|
|
|
d = (2 * a + eps) / (b + c + eps)
|
|
|
|
else:
|
|
|
|
b = torch.sum(input * input, 1) + eps
|
|
|
|
c = torch.sum(target * target, 1) + eps
|
|
|
|
d = (2 * a) / (b + c)
|
2021-03-11 10:32:37 +08:00
|
|
|
|
2023-05-15 14:20:42 +08:00
|
|
|
loss = 1 - d
|
|
|
|
if weight is not None:
|
|
|
|
assert weight.ndim == loss.ndim
|
|
|
|
assert len(weight) == len(pred)
|
|
|
|
loss = weight_reduce_loss(loss, weight, reduction, avg_factor)
|
|
|
|
return loss
|
|
|
|
|
|
|
|
|
|
|
|
@MODELS.register_module()
|
|
|
|
class DiceLoss(nn.Module):
|
2021-03-11 10:32:37 +08:00
|
|
|
|
|
|
|
def __init__(self,
|
2023-05-15 14:20:42 +08:00
|
|
|
use_sigmoid=True,
|
|
|
|
activate=True,
|
2021-03-11 10:32:37 +08:00
|
|
|
reduction='mean',
|
2023-05-15 14:20:42 +08:00
|
|
|
naive_dice=False,
|
2021-03-11 10:32:37 +08:00
|
|
|
loss_weight=1.0,
|
2021-03-30 00:49:54 +08:00
|
|
|
ignore_index=255,
|
2023-05-15 14:20:42 +08:00
|
|
|
eps=1e-3,
|
|
|
|
loss_name='loss_dice'):
|
|
|
|
"""Compute dice loss.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
use_sigmoid (bool, optional): Whether to the prediction is
|
|
|
|
used for sigmoid or softmax. Defaults to True.
|
|
|
|
activate (bool): Whether to activate the predictions inside,
|
|
|
|
this will disable the inside sigmoid operation.
|
|
|
|
Defaults to True.
|
|
|
|
reduction (str, optional): The method used
|
|
|
|
to reduce the loss. Options are "none",
|
|
|
|
"mean" and "sum". Defaults to 'mean'.
|
|
|
|
naive_dice (bool, optional): If false, use the dice
|
|
|
|
loss defined in the V-Net paper, otherwise, use the
|
|
|
|
naive dice loss in which the power of the number in the
|
|
|
|
denominator is the first power instead of the second
|
|
|
|
power. Defaults to False.
|
|
|
|
loss_weight (float, optional): Weight of loss. Defaults to 1.0.
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
ignore_index (int, optional): The label index to be ignored.
|
2023-05-15 14:20:42 +08:00
|
|
|
Default: 255.
|
|
|
|
eps (float): Avoid dividing by zero. Defaults to 1e-3.
|
|
|
|
loss_name (str, optional): Name of the loss item. If you want this
|
|
|
|
loss item to be included into the backward graph, `loss_` must
|
|
|
|
be the prefix of the name. Defaults to 'loss_dice'.
|
|
|
|
"""
|
|
|
|
|
2022-09-19 14:06:29 +08:00
|
|
|
super().__init__()
|
2023-05-15 14:20:42 +08:00
|
|
|
self.use_sigmoid = use_sigmoid
|
2021-03-11 10:32:37 +08:00
|
|
|
self.reduction = reduction
|
2023-05-15 14:20:42 +08:00
|
|
|
self.naive_dice = naive_dice
|
2021-03-11 10:32:37 +08:00
|
|
|
self.loss_weight = loss_weight
|
2023-05-15 14:20:42 +08:00
|
|
|
self.eps = eps
|
|
|
|
self.activate = activate
|
2021-03-11 10:32:37 +08:00
|
|
|
self.ignore_index = ignore_index
|
2021-09-24 15:08:28 +08:00
|
|
|
self._loss_name = loss_name
|
2021-03-11 10:32:37 +08:00
|
|
|
|
2021-03-30 00:49:54 +08:00
|
|
|
def forward(self,
|
|
|
|
pred,
|
|
|
|
target,
|
2023-05-15 14:20:42 +08:00
|
|
|
weight=None,
|
2021-03-30 00:49:54 +08:00
|
|
|
avg_factor=None,
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
reduction_override=None,
|
|
|
|
ignore_index=255,
|
|
|
|
**kwargs):
|
2023-05-15 14:20:42 +08:00
|
|
|
"""Forward function.
|
|
|
|
|
|
|
|
Args:
|
|
|
|
pred (torch.Tensor): The prediction, has a shape (n, *).
|
|
|
|
target (torch.Tensor): The label of the prediction,
|
|
|
|
shape (n, *), same shape of pred.
|
|
|
|
weight (torch.Tensor, optional): The weight of loss for each
|
|
|
|
prediction, has a shape (n,). Defaults to None.
|
|
|
|
avg_factor (int, optional): Average factor that is used to average
|
|
|
|
the loss. Defaults to None.
|
|
|
|
reduction_override (str, optional): The reduction method used to
|
|
|
|
override the original reduction method of the loss.
|
|
|
|
Options are "none", "mean" and "sum".
|
|
|
|
|
|
|
|
Returns:
|
|
|
|
torch.Tensor: The calculated loss
|
|
|
|
"""
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
one_hot_target = target
|
|
|
|
if (pred.shape != target.shape):
|
|
|
|
one_hot_target = _expand_onehot_labels_dice(pred, target)
|
2021-03-11 10:32:37 +08:00
|
|
|
assert reduction_override in (None, 'none', 'mean', 'sum')
|
|
|
|
reduction = (
|
|
|
|
reduction_override if reduction_override else self.reduction)
|
2023-05-15 14:20:42 +08:00
|
|
|
if self.activate:
|
|
|
|
if self.use_sigmoid:
|
|
|
|
pred = pred.sigmoid()
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
elif pred.shape[1] != 1:
|
|
|
|
# softmax does not work when there is only 1 class
|
|
|
|
pred = pred.softmax(dim=1)
|
2021-03-30 00:49:54 +08:00
|
|
|
loss = self.loss_weight * dice_loss(
|
2021-03-11 10:32:37 +08:00
|
|
|
pred,
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
one_hot_target,
|
2023-05-15 14:20:42 +08:00
|
|
|
weight,
|
|
|
|
eps=self.eps,
|
2021-03-11 10:32:37 +08:00
|
|
|
reduction=reduction,
|
2023-05-15 14:20:42 +08:00
|
|
|
naive_dice=self.naive_dice,
|
2021-03-11 10:32:37 +08:00
|
|
|
avg_factor=avg_factor,
|
[Fix] Added ignore_index and one hot encoding for dice loss (#3237)
Added ignore_index param to forward(),
also implemented one hot encoding to ensure the dims of target matches
pred.
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.
## Motivation
Please describe the motivation of this PR and the goal you want to
achieve through this PR.
Attempted to solve the problems mentioned by #3172
## Modification
Please briefly describe what modification is made in this PR.
Added ignore_index into forward function (although the dice loss itself
does not actually take account for it for some reason).
Added _expand_onehot_labels_dice, which takes the target with shape [N,
H, W] into [N, num_classes, H, W].
## BC-breaking (Optional)
Does the modification introduce changes that break the
backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the
downstream projects should modify their code to keep compatibility with
this PR.
## Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases
here, and update the documentation.
## Checklist
1. Pre-commit or other linting tools are used to fix the potential lint
issues.
2. The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
3. If the modification has potential influence on downstream projects,
this PR should be tested with downstream projects, like MMDet or
MMDet3D.
4. The documentation has been modified accordingly, like docstring or
example tutorials.
This is my first time contributing to open-source code, so I might have
made some stupid mistakes. Please don't hesitate to point it out.
2023-08-09 10:16:22 +08:00
|
|
|
ignore_index=self.ignore_index)
|
2023-05-15 14:20:42 +08:00
|
|
|
|
2021-03-11 10:32:37 +08:00
|
|
|
return loss
|
2021-09-24 15:08:28 +08:00
|
|
|
|
|
|
|
@property
|
|
|
|
def loss_name(self):
|
|
|
|
"""Loss Name.
|
|
|
|
|
|
|
|
This function must be implemented and will return the name of this
|
|
|
|
loss function. This name will be used to combine different loss items
|
|
|
|
by simple sum operation. In addition, if you want this loss item to be
|
|
|
|
included into the backward graph, `loss_` must be the prefix of the
|
|
|
|
name.
|
|
|
|
Returns:
|
|
|
|
str: The name of this loss item.
|
|
|
|
"""
|
|
|
|
return self._loss_name
|