6 Commits

Author SHA1 Message Date
Siddharth Ancha
5d49918b3c
[Fix] Switch order of reduce_zero_label and applying label_map (#2500)
## Motivation

I want to fix a bug through this PR. The bug occurs when two options --
`reduce_zero_label=True`, and custom classes are used.
`reduce_zero_label` remaps the GT seg labels by remapping the zero-class
to 255 which is ignored. Conceptually, this should occur *before* the
`label_map` is applied, which maps *already reduced labels*. However,
currently, the `label_map` is applied before the zero label is reduced.

## Modification

The modification is simple:
- I've just interchanged the order of the two operations by moving 4
lines from bottom to top.
- I've added a test that passes when the fix is introduced, and fails on
the original `master` branch.

## BC-breaking (Optional)

I do not anticipate this change braking any backward-compatibility.

## Checklist

- [x] Pre-commit or other linting tools are used to fix the potential
lint issues.
  - _I've fixed all linting/pre-commit errors._
- [x] The modification is covered by complete unit tests. If not, please
add more unit test to ensure the correctness.
  - _I've added a unit test._ 
- [x] If the modification has potential influence on downstream
projects, this PR should be tested with downstream projects, like MMDet
or MMDet3D.
  - _I don't think this change affects MMDet or MMDet3D._
- [x] The documentation has been modified accordingly, like docstring or
example tutorials.
- _This change fixes an existing bug and doesn't require modifying any
documentation/docstring._
2023-01-19 15:01:40 +08:00
Yzichen
28488851fd
fix bug about label_map (#1445)
* fix bug about label_map

* Update mmseg/datasets/pipelines/loading.py

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>

* lint

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Co-authored-by: MeowZheng <meowzheng@outlook.com>
2022-04-09 21:11:47 +08:00
Junjun2016
441be4e435
[Dcos] Add header for files (#796)
* Add header for files

* Delete header in config files
2021-08-16 23:16:55 -07:00
yinchimaoliang
1fb54ac8c0
change 'reduct' to 'reduce' (#298) 2020-12-13 10:06:01 -08:00
Iago González
b8c2f913e4
Add support for custom classes (#71)
* Support for custom classes

* Fix test

* Fix pre-commit

* Add pipeline logic for custom classes

* Fix minor issues, fix test

* Fix issues from PR review

* Fix tests

* Remove palette as str

* Rename old_to_new_ids to label_map

* Test for load_anns

* Remove get_palette function

* fixed temp

* Add subset of palette, remove palette as arg

* minor update

Co-authored-by: Jiarui XU <xvjiarui0826@gmail.com>
2020-09-16 21:33:01 +08:00
Jiarui XU
b2724da80b init commit 2020-07-10 02:39:01 +08:00