From 644cdd4e323117db58e76cafa10a51c111de1460 Mon Sep 17 00:00:00 2001
From: Dahun Kim <mcahny@github.com>
Date: Tue, 31 Aug 2021 19:18:31 +0900
Subject: [PATCH] readme

---
 README.md                                |  8 --------
 configs/oln_box/oln_box.py               |  4 ++--
 mmdet/models/dense_heads/oln_rpn_head.py | 13 ++++++-------
 3 files changed, 8 insertions(+), 17 deletions(-)

diff --git a/README.md b/README.md
index 3086bf7..2bef848 100644
--- a/README.md
+++ b/README.md
@@ -22,14 +22,6 @@ Humans can recognize novel objects in this image despite having never seen them
 <img src="./images/epic.png" width="500"> <img src="./images/oln_overview.png" width="500"> <br/>
 
 
-## Cross-category generalization on COCO
-
-We train OLN on COCO VOC categories, and test on non-VOC categories. Note our AR@k evaluation does not count those proposals on the 'seen' classes into the budget (k), to avoid evaluating recall on see-class objects.
-
-|     Method     |  AUC  | AR@10 | AR@30 | AR@100 | AR@300 | AR@1000 | Download |
-|:--------------:|:-----:|:-----:|:-----:|:------:|:------:|:-------:|:--------:|
-|    OLN-Box     | 24.8  | 18.0  | 26.4  |  33.4  |  39.0  |  45.0   | [model](https://drive.google.com/uc?id=1uL6TRhpSILvWeR6DZ0x9K9VywrQXQvq9) |
-
 
 ## Disclaimer
 
diff --git a/configs/oln_box/oln_box.py b/configs/oln_box/oln_box.py
index 23fba31..a6f4cc6 100644
--- a/configs/oln_box/oln_box.py
+++ b/configs/oln_box/oln_box.py
@@ -105,7 +105,7 @@ model = dict(
             nms_pre=2000,
             nms_post=2000,
             max_num=2000,
-            nms_thr=1.0,  # nms is not used.
+            nms_thr=0.7,
             min_bbox_size=0),
         rcnn=dict(
             assigner=dict(
@@ -129,7 +129,7 @@ model = dict(
             nms_pre=2000,
             nms_post=2000,
             max_num=2000,
-            nms_thr=1.0,  # nms is not used.
+            nms_thr=0.7,
             min_bbox_size=0),
         rcnn=dict(
             score_thr=0.0,
diff --git a/mmdet/models/dense_heads/oln_rpn_head.py b/mmdet/models/dense_heads/oln_rpn_head.py
index 6a4b390..4137101 100644
--- a/mmdet/models/dense_heads/oln_rpn_head.py
+++ b/mmdet/models/dense_heads/oln_rpn_head.py
@@ -688,13 +688,12 @@ class OlnRPNHead(RPNHead):
                 ids = ids[valid_inds]
 
         nms_cfg = dict(type='nms', iou_threshold=cfg.nms_thr)
-        
-        if nms_cfg in [0.0, 1.0]:
-            # No NMS:
-            dets = torch.cat([proposals, scores.unsqueeze(1)], 1)
-        else:
-            dets, keep = batched_nms(proposals, scores, ids, nms_cfg)
-            return dets[:cfg.nms_post]
+
+        # No NMS:
+        dets = torch.cat([proposals, scores.unsqueeze(1)], 1)
+        # else:
+        #     dets, keep = batched_nms(proposals, scores, ids, nms_cfg)
+        #     return dets[:cfg.nms_post]
         
         return dets