mirrors/yolov5
1
0
Fork 0
mirror of https://github.com/ultralytics/yolov5.git synced 2025-06-03 14:49:29 +08:00
Code Issues Projects Releases Wiki Activity

Security improvements for subprocess.run() (#10943)

Browse Source 
* Security improvements

* Security improvements

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This commit is contained in:
Glenn Jocher 2023-02-09 17:18:27 +04:00 committed by GitHub
parent e326252ee4
commit 61407c93cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
utils/general.py
View File

@ -649,9 +649,9 @@ def download(url, dir='.', unzip=True, delete=True, curl=False, threads=1, retry
if is_zipfile(f): if is_zipfile(f):
unzip_file(f, dir) # unzip unzip_file(f, dir) # unzip
elif is_tarfile(f): elif is_tarfile(f):
subprocess.run(f'tar xf {f} --directory {f.parent}', shell=True) # unzip subprocess.run(['tar', 'xf', f, '--directory', f.parent], check=True) # unzip
elif f.suffix == '.gz': elif f.suffix == '.gz':
subprocess.run(f'tar xfz {f} --directory {f.parent}', shell=True) # unzip subprocess.run(['tar', 'xfz', f, '--directory', f.parent], check=True) # unzip
if delete: if delete:
f.unlink() # remove zip f.unlink() # remove zip
@ -1023,7 +1023,7 @@ def print_mutation(keys, results, hyp, save_dir, bucket, prefix=colorstr('evolve
if bucket: if bucket:
url = f'gs://{bucket}/evolve.csv' url = f'gs://{bucket}/evolve.csv'
if gsutil_getsize(url) > (evolve_csv.stat().st_size if evolve_csv.exists() else 0): if gsutil_getsize(url) > (evolve_csv.stat().st_size if evolve_csv.exists() else 0):
subprocess.run(f'gsutil cp {url} {save_dir}', shell=True) # download evolve.csv if larger than local subprocess.run(['gsutil', 'cp', f'{url}', f'{save_dir}']) # download evolve.csv if larger than local
# Log to evolve.csv # Log to evolve.csv
s = '' if evolve_csv.exists() else (('%20s,' * n % keys).rstrip(',') + '\n') # add header s = '' if evolve_csv.exists() else (('%20s,' * n % keys).rstrip(',') + '\n') # add header
@ -1047,7 +1047,7 @@ def print_mutation(keys, results, hyp, save_dir, bucket, prefix=colorstr('evolve
for x in vals) + '\n\n') for x in vals) + '\n\n')
if bucket: if bucket:
subprocess.run(f'gsutil cp {evolve_csv} {evolve_yaml} gs://{bucket}', shell=True) # upload subprocess.run(['gsutil', 'cp', f'{evolve_csv}', f'{evolve_yaml}', f'gs://{bucket}']) # upload
def apply_classifier(x, model, img, im0): def apply_classifier(x, model, img, im0):